search

cyclejs-community / create-cycle-app

Create Cycle.js apps with no build configuration.
ISC License
238 stars 21 forks source link

Duplicate meta tags for favicon #121

Closed jikkai closed 5 years ago

jikkai commented 6 years ago

Code to reproduce the issue:

create-cycle-app demo
cd demo
npm i
npm run build

Expected behavior:

Only one meta tag for favicon in complied html.

Actual behavior:

/public/index.html#L6

/public/index.html#L93

Accoding to this two files, there will be two duplicate favicon in complied html.

output html:

    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <link rel="shortcut icon" type="image/png" href="favicon.png" />
    <title>Cycle App</title>
  <link rel="shortcut icon" href="favicon.png"></head>

Versions of packages used:

create-cycle-app@4.0.0

olpeh commented 5 years ago

Tried looking into the issue, but was unable to reproduce the duplicate favicon meta tag.

jvanbruegge commented 5 years ago

Most likely due to an old version of the template, thanks for looking into it