cyclejs-community / create-cycle-app

Create Cycle.js apps with no build configuration.
ISC License
237 stars 21 forks source link

Add CSS to core flavours #58

Open SteveALee opened 7 years ago

SteveALee commented 7 years ago

Any real app will use CSS (or something that compiles to it) for styling, not just code managed classes used for DOM event hooks or component isolation. However the built in flavors have no CSS at all.

A minimum would be to simply provide a static styles.css refed from index.html

A more useful example might be to use webpack loaders - but there are many options even with the basics.

geovanisouza92 commented 7 years ago

Another option is use freestyle (or typestyle) directly from the current JS-focused setup. We need to find what is the more common option the community uses...

Em qua, 4 de jan de 2017 08:10, Steve Lee notifications@github.com escreveu:

Any real app will use CSS (or something that compiles to it) for styling, not just code managed classes used for DOM event hooks or component isolation. However the built in flavors have no CSS at all.

A minimum would be to simply provide a static styles.css refed from index.html

A more useful example might be to use webpack loaders - but there are many options even with the basics.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cyclejs-community/create-cycle-app/issues/58, or mute the thread https://github.com/notifications/unsubscribe-auth/AAv-ue28anScBvCXTawVLupxmIfeHpUWks5rO3APgaJpZM4Lad5j .

SteveALee commented 7 years ago

Free-style looks interesting but probably too complex.

As an aside, I'm looking for a way to declare component specific css but simple dom updates to style sheets might be easier

SteveALee commented 7 years ago

Ooh, typestyle looks great.

As you say though we need to know what community are using.

nickbalestra commented 7 years ago

+1 on typestyle

geovanisouza92 commented 7 years ago

@SteveALee We should also decide if component-specific CSS should be handled in the markup-level (html, css imports) or bundler-level (webpack, e.g.).

nickbalestra commented 7 years ago

I really like how it was done here: https://github.com/wmaurer/cyclejs-fractals/blob/master/src/app.ts#L5-L6