[CCA-Diversity] Add tests

cyclejs-community / create-cycle-app

Create Cycle.js apps with no build configuration.

ISC License

237 stars 21 forks source link

[CCA-Diversity] Add tests #94

Open nickbalestra opened 7 years ago

nickbalestra commented 7 years ago

As per the work done in the 1-fit-all flavor, only within jest

jvanbruegge commented 7 years ago

What is the benefit if using Jest? I looked at the docs and cannot really find one, automocking is something that i dont want too. In cycle all functions (should) are referential transperant, so no need for mocking anything Jest looks cool for imperative React code, but i dont think there is a big gain for cycle

nickbalestra commented 7 years ago

Jest is just built on top of jasmine, I don't think that it's value is for react only. I also think that imperative code is not really an argument here. (btw automocking is not on by default since v 14 if i remember right). Few things that comes to my mind:

Test are run in parallel, therefore is fast.
Failing test run first
Snapshots could be valuable in cycle as well
custom matchers are pretty awesome, and I think we could definitely write some good custom matchers for cycle apps.

jvanbruegge commented 7 years ago

Didn't know about the parallel and the custom matchers, yes, that could indeed be nice