cyclejs-community / cycle-regl

A Cycle.js driver for regl, a declarative and functional interface to WebGL
MIT License
6 stars 0 forks source link

Clean up DOM when using `container` option upon re-running or Cycle `.dispose()` being called #1

Open wyqydsyq opened 7 years ago

wyqydsyq commented 7 years ago

When the Cycle instance running this driver calls .dispose() (e.g. in response to cycle-restart receiving a HMR update) any generated elements/objects should be cleaned up, this already happens implicitly when using the fullscreen automatic element or the canvas option as Regl directly replaces those elements when running the next time, but if specifying container you end up with multiple canvas elements. This might be the intended behaviour, I'm just opening it as an issue because it's not the behaviour I expected.

For example, if you use something like this and get a HMR update:

makeReglDriver({
  container: document.getElementById('viewport')
}),

canvas elements from previous executions will remain inside the #viewport element, a new canvas with the new result is appended to #viewport.

My guesses for a potential solution would be one of:

Widdershin commented 7 years ago

This is a bug, after dispose() the world should be as it was prior to the driver being created.

There is currently no disposal implemented on this driver, and there definitely should be.

Are you interested in having a go at making a pull request? I'd be happy to review it and merge it 😄