search

cyclejs-community / cyclic-router

Router Driver built for Cycle.js
MIT License
109 stars 25 forks source link

Initial refactor for Cycle Unified #184

Closed EnigmaCurry closed 7 years ago

EnigmaCurry commented 7 years ago

I'm following the Cycle.js Unified release notes for updating drivers and I've made some initial refactorings for cyclic-router.

Still getting some test errors, so please don't merge this yet, but I wanted to share what I've got so far. I'm still investigating, so please let me know of any tips.

EnigmaCurry commented 7 years ago

@TylorS the only tests still failing are timeouts. If you can give me any pointers, I'll keep hacking on this.

TylorS commented 7 years ago

I don't really have the time to maintain this library, hence #183, if you're interested please let me know there. Otherwise, if you're not interested, just let me know when this is ready to merge and I'll do a major release.

EnigmaCurry commented 7 years ago

OK, that's cool. If I can figure out these test failures I'll let you know about helping with maintenance.

EnigmaCurry commented 7 years ago

I'm closing this, because I couldn't figure out my issues. The single file router from https://github.com/garrydzeng/cycle-page/ was easier for me to grok, although it's probably a lot less powerful than this. Sorry, hope someone else can pick up where I left off. Thanks again for all you do Tylor, your work is much appreciated!

ntilwalli commented 7 years ago

@EnigmaCurry @TylorS See https://github.com/cyclejs-community/cyclic-router/issues/185