search

cyclejs-community / one-fits-all

The one-fits-all flavor for create-cycle-app
MIT License
34 stars 8 forks source link

Allow developers to add devServer config #49

Closed baranovxyz closed 7 years ago

baranovxyz commented 7 years ago

In webpack.config.js

jvanbruegge commented 7 years ago

There is a better fix for that. Move the user config at the bottom of the configs/webpack.config.js Then it will overwrite the flavor config

baranovxyz commented 7 years ago

There is a better fix for that. Move the user config at the bottom of the configs/webpack.config.js Then it will overwrite the flavor config

Moving from

module.exports = createConfig([
  customConfig(userConfig),
  tslint(),
  ...
])

to 

module.exports = createConfig([
  tslint(),
  ...,
  customConfig(userConfig)
])

Does not work for me...

jvanbruegge commented 7 years ago

Weird

jvanbruegge commented 7 years ago

Found the issue and fixed it, now the userConfig always overwrites predefined values