cyclejs-community / redux-cycles

Bring functional reactive programming to Redux using Cycle.js
MIT License
745 stars 30 forks source link

Package dependencies #14

Closed lmatteis closed 7 years ago

lmatteis commented 7 years ago

I'm a bit of a newb with package.json and npm stuff, but it doesn't seem right that xstream and run are inside devDependencies. For instance, the jsonp driver has xstream as a peerDependency and run as a dependency: https://github.com/Widdershin/cycle-core/blob/bbad3d6ef832e6131f1c81a32de856b3d56ecda2/jsonp/package.json#L12

@nickbalestra @goshakkk not sure how peerDependencies work but maybe you guys can help?

nickbalestra commented 7 years ago

Yes those are actual dependencies, not devDepenencies

lmatteis commented 7 years ago

https://github.com/cyclejs-community/redux-cycle-middleware/pull/15