search

cyclejs-community / redux-cycles

Bring functional reactive programming to Redux using Cycle.js
MIT License
745 stars 30 forks source link

Travis for `example` dir #17

Closed lmatteis closed 7 years ago

lmatteis commented 7 years ago

So I'd like to test the example project (which is meant to be a separate project with its own package.json) using travis. Any thoughts on configuring this? @nickbalestra

nickbalestra commented 7 years ago

why not making this into a monorepo? Perhpash using something like lerna for example..

nickbalestra commented 7 years ago

Othwerwise You can set a script field in the travis yaml config:

something like:

...
script: cd npm install && npm test && cd ../example && npm install && npm test

Here a cool post about it

lmatteis commented 7 years ago

Thanks! That works. I'm getting the cycle/time problem also on travis https://travis-ci.org/cyclejs-community/redux-cycle-middleware/builds/196599833#L1046

Reference PR: https://github.com/cyclejs-community/redux-cycle-middleware/pull/18

nickbalestra commented 7 years ago

Weird, as I see it was correctly installed -> https://travis-ci.org/cyclejs-community/redux-cycle-middleware/builds/196599833#L664

lmatteis commented 7 years ago

Maybe it's something with how mocha runs/compiles the code? Not sure

lmatteis commented 7 years ago

Even with jest it fails: https://travis-ci.org/cyclejs-community/redux-cycle-middleware/builds/196612034#L1246

https://travis-ci.org/cyclejs-community/redux-cycles/builds/196984686#L1246

lmatteis commented 7 years ago

Maybe @goshakkk @Widdershin can help solve the mystery?

lmatteis commented 7 years ago

This is closed as it was a problem with cyclejs/time and the fact that it was compiling into Index.js rather than index.js