cyclejs-community / redux-cycles

Bring functional reactive programming to Redux using Cycle.js

MIT License

745 stars 30 forks source link

Add ESLint #29

Closed lmatteis closed 7 years ago

lmatteis commented 7 years ago

9

Added ESLint support with airbnb config. Fixed some errors in combineCycles only. Waiting for #28 to be merged before fixing the other files.

lmatteis commented 7 years ago

Do you guys like the trailing commas and the extra parens for single arguments? I'm not really convinced. Maybe there's a more minimal linter around.

nickbalestra commented 7 years ago

You can add an eslintrc file and mute those rules

On 12 Feb 2017, at 11:26, Luca Matteis notifications@github.com wrote:

Do you guys like the trailing commas and the extra parens for single arguments? I'm not really convinced. Maybe there's a more minimal linter around.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.

lmatteis commented 7 years ago

Ok pushed a more minimal ESLint config - pretty simple with no semicolons.