search

cyclejs-community / redux-cycles

Bring functional reactive programming to Redux using Cycle.js
MIT License
745 stars 30 forks source link

Add TypeScript type declaration #37

Closed goodmind closed 7 years ago

goodmind commented 7 years ago

/сс @Widdershin

goodmind commented 7 years ago

/cc @lmatteis

goodmind commented 7 years ago

@Widdershin when you can merge this? Or should I write some type tests like in DefinitelyTyped repository?

Widdershin commented 7 years ago

@goodmind if @lmatteis is happy I will merge this. I held off merging because this is @lmatteis and @nickbalestra's project, I'm just the community coordinator. 😸

lmatteis commented 7 years ago

I can't really test it because I don't use Typescript. However I trust @Widdershin that's a beneficial thing to have (and that it works). So I'll go ahead and accept it 👍