search

cyclejs-community / redux-cycles

Bring functional reactive programming to Redux using Cycle.js
MIT License
745 stars 30 forks source link

Typescript definitions are not added to the build #40

Closed bzums closed 7 years ago

bzums commented 7 years ago

Hey,

it seems like there are typescript type definitions (see #37) but there are not added to the build and therefore not available when using this lib in your project without further ado.

Or am I missing something here? If not, I would happily provide a PR.

Best

bzums commented 7 years ago

Ah ok I think the version is just not published with type informations, so would it be possible to do so?

Best

Widdershin commented 7 years ago

@bzums go ahead and make a pull request 👍

bzums commented 7 years ago

@Widdershin would it also be possible to publish version 0.4.1 to npm or are there any reasons speaking against it?

Widdershin commented 7 years ago

I don't have publish rights so that would be up to Luca or Nick.

On 27/06/2017 7:13 PM, "Bastian Sieker" notifications@github.com wrote:

@Widdershin https://github.com/widdershin would it also be possible to publish version 0.4.1 to npm or are there any reasons speaking against it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cyclejs-community/redux-cycles/issues/40#issuecomment-311273200, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYUHdwZaOy1XD5BQqnM2RJf0fUPeOjaks5sIKuAgaJpZM4ODReP .

nickbalestra commented 7 years ago

Same. @lmatteis feel free to add me and Nick as publisher so we can help with that

lmatteis commented 7 years ago

Sorry for the late reply. Should be on npm now :)