cyclejs-community / redux-cycles

Bring functional reactive programming to Redux using Cycle.js
MIT License
745 stars 30 forks source link

[WIP] Modularized code #7

Closed nickbalestra closed 7 years ago

nickbalestra commented 7 years ago

@lmatteis in direction of adding tests, I've modularised the code as it was incapsulating everything, this way should be easier to unit test it as we now have separate modules for:

nickbalestra commented 7 years ago

I think that without relying on the 'singleton-ish' part will be hard to make this work...(I've tried to implement @goshakkk idea without luck). If we believe that we don't need to add unit test, you can close this, otherwise I don't see many alternatives.

goshacmd commented 7 years ago

Then maybe let's just extract the cycle merge utility into a separate file, but keep the drivers inline?

nickbalestra commented 7 years ago

@I'll add some unit tests next, then this should be also ready to go.

lmatteis commented 7 years ago

Ok I've enabled travis. I'm not sure why it's not showing up for existing PRs. Maybe once you push?

nickbalestra commented 7 years ago

Rebased and push, all working as expected :) thanks!