Closed nickbalestra closed 7 years ago
I think that without relying on the 'singleton-ish' part will be hard to make this work...(I've tried to implement @goshakkk idea without luck). If we believe that we don't need to add unit test, you can close this, otherwise I don't see many alternatives.
Then maybe let's just extract the cycle merge utility into a separate file, but keep the drivers inline?
@I'll add some unit tests next, then this should be also ready to go.
Ok I've enabled travis. I'm not sure why it's not showing up for existing PRs. Maybe once you push?
Rebased and push, all working as expected :) thanks!
@lmatteis in direction of adding tests, I've modularised the code as it was incapsulating everything, this way should be easier to unit test it as we now have separate modules for: