search

cyclejs / todomvc-cycle

TodoMVC example implemented in Cycle.js
https://cyclejs.github.io/todomvc-cycle/
MIT License
240 stars 62 forks source link

TaskList does not receive Task actions #35

Open maiermic opened 8 years ago

maiermic commented 8 years ago

You cannot delete, edit or toggle active-state of a Task. Even though actions produced by the intent of Task are triggered, TaskList does not receive those item actions.

cdetrio commented 8 years ago

The regression was introduced in the June 15 commit. Reset to the previous commit git reset --hard 2da07d9dd5231c0148d133c7f596552a6b97148c followed by npm install and Task actions work.

maiermic commented 8 years ago

I guess this issue is related to https://github.com/cyclejs/cyclejs/issues/370, because isolate is called twice after the June 15 commit.

When using the router the WelcomePage gets called twice, and any isolated child components of WelcomePage seem to lose track of their namespace/scope when it's called the second time. -- https://github.com/cyclejs/cyclejs/issues/370#issuecomment-237131125

maiermic commented 8 years ago

This bug is caused by xstream and is introduced by version 5.2.2. If you downgrade to xstream@5.2.1 it works fine.