search

cyclestreets / android

The Android app brings CycleStreets routing and turn-by-turn live navigation to your phone.
https://www.cyclestreets.net/mobile/android/
GNU General Public License v3.0
213 stars 217 forks source link

Footprints in Itinerary don't show #515

Closed HilaryN closed 1 year ago

HilaryN commented 2 years ago

The footprints, which indicate that a segment is a walking segment in the Itinerary, don't show unless a segment is selected, because they are white on a white background. It would be nice to be able to see these even if a segment isn't selected.

image

HilaryN commented 2 years ago

(I'm doing a fix alongside #497 )

HilaryN commented 2 years ago

I've created a new image from the old one and I've fudged this to make all the itinerary steps show as walking, just to get an idea of how the footprints would look with different types of arrow:

Screenshot_1662128482

mvl22 commented 2 years ago

I would strongly recommend not having different footprint positioning depending on the arrow. Visually this breaks standard design rules about consistency.

Basically just pick a location, e.g. bottom right of the square, and stick to it. If you set it to overlay the arrow with a higher z-index then it will always show and not be lost. Consider putting a white circle around the feet so that it is always visually separate over the arrow as a small blob.

HilaryN commented 2 years ago

The positioning here is the same for all the arrows - I just wanted to see how it would actually look with different arrows.

oliverlockwood commented 2 years ago

The positioning here is the same for all the arrows - I just wanted to see how it would actually look with different arrows.

What I notice upon close inspection, is that the arrows have a clear background, and then the footprints have a white background. This becomes obvious in the entries in the instructions which spill onto a second line.

In my opinion:

  1. if there is to be a background, this should be part of the layout such that it is either there or not there, consistently for the whole relevant image area, regardless of whether there are footprints, and regardless of the length of the instruction line.
  2. Both the arrow (as currently) and footprint images should have a clear background.
  3. We would benefit from @si-the-pie's vector image drawing skills to define a footprints icon SVG which we can then import into an Android vector icon (we did this before, for all the arrows, and it made things look a lot better).