search

cyclestreets / cyclescape

Cyclescape - cycle campaign group toolkit
https://www.cyclescape.org/
MIT License
33 stars 15 forks source link

Move keys to web-based admin control panel #491

Open mvl22 opened 8 years ago

mvl22 commented 8 years ago

Looking at the settings at: https://github.com/cyclestreets/cyclescape-chef/tree/master/data-bags/secrets

including the e-mail parameters, I wonder whether all this can be moved into a control panel based arrangement. As far as I can see, none of them are actually required at setup time.

Once set up, the site should then be in a state of not running until the control panel (being the only section that would be enabled) has these filled in. The person setting up the site, being the first person to access the new installation, would then have to enter them, effectively enabling the site. As long as that page is only run if a database connection is properly established, I can't see any security risk here.

mvl22 commented 5 years ago

Is this now done @nikolai-b?

nikolai-b commented 5 years ago

No, we have the site config but moving the DNS, Rollbar etc. keys is not easy as they are loaded when rails boots up. I can investigate changing them but we'd also need to restart all the workers when they are changed.