cyclestreets / cyclescape

Cyclescape - cycle campaign group toolkit
https://www.cyclescape.org/
MIT License
33 stars 15 forks source link

Lines concatenated (i.e. formatting lost) in emails #827

Closed wookey closed 5 years ago

wookey commented 5 years ago

All cyclescape emails since Friday 14 Dec 2018 15:17 have arrived with the text body concatenated onto one line (and then split at 73chars). The last mail (I saw) that was correctly formatted was: Fri, 14 Dec 2018 14:03:17 +0000

It looks like some change made around this time broken things pretty badly.

The mails are now pretty-much illegible: [-- Autoview using /usr/bin/w3m -I 'UTF-8' -dump -T text/html '/tmp/mutt.html' --]
wookey added a message to the thread
On 2018-12-09 21:18 +0000, Dave Fox wrote: > I put the link and plan of the
site showing route (solid purple) in the Issue document, not realising it
wouldn't show up in this Discussion thread (it's the first time I've used
Cyclescape). > > Please add your comments here: > https://clayfarmgarden.org/
consultation/consultation-the-cycle-path/ Very depressing set of responses so
far which are all about making as useless as possible a route otherwise
cyclists might use it and/or go too fast. As Jim said this whole development
has done a horrible job of making cycle routes available as residents move in
with various routes that only get connected after (sometimes years after)
people move in and choose their transport method. This path would appear to be
another such item. And Nine Wells is busy doing the same thing, although not
quite as bad. There is already connectivity to Pinnington Close, so maybe it's
OK to have a relatively meandering route through the garden. But chicanes are
dumb, as Matthew says. I've not been this way for a long time - time to take a
look-see I guess. Wookey -- Principal hats: Linaro, Debian, Wookware, ARM http:
//wookware.org/

I see that cyclescape is sending out multipart mails (so I'm not sure why I'm seeing the w3m dump of the html mail). But the text version is also all on one line:

On 2018-12-09 21:18 +0000, Dave Fox wrote: > I put the link and plan of the site showing route (solid purple)
+in the Issue document, not realising it wouldn't show up in this Discussion thread (it's the first time I've
+used Cyclescape). > > Please add your comments here: >
+https://clayfarmgarden.org/consultation/consultation-the-cycle-path/ Very depressing set of responses so far
+which are all about making as useless as possible a route otherwise cyclists might use it and/or go too fast. +As Jim said this whole development has done a horrible job of making cycle routes available as residents move +in with various routes that only get connected after (sometimes years after) people move in and choose their
+transport method. This path would appear to be another such item. And Nine Wells is busy doing the same thing, +although not quite as bad. There is already connectivity to Pinnington Close, so maybe it's OK to have a
+relatively meandering route through the garden. But chicanes are dumb, as Matthew says. I've not been this way +for a long time - time to take a look-see I guess. Wookey -- Principal hats: Linaro, Debian, Wookware, ARM
+http://wookware.org/

(Those '+' symbols are where my screen has wrapped the single very long line)

It is possible that the problem is reading in the incoming mails, rather than sending them out. But somewhere along the way all the linefeeds, and thus formatting, is being lost.

The net result that the output is currently totally unusable for people reading text or console email, and presumably the html version isn't right either. What was changed then and can we please put it back, or fix it?

Happy to help track this down if it's not obvious what's up at your end.

mvl22 commented 5 years ago

Duplicate of #820 basically.

nikolai-b commented 5 years ago

820 is todo with the richtext editor not being initialised. This is sadly a dup of #826 , the fact that we hadn't considered inbound emails fully. Thanks for the report and I'm very sorry about this! I'm going to close in favour of #826.

wookey commented 5 years ago

On 2018-12-15 16:27 +0000, Nikolai wrote:

820 is todo with the richtext editor not being initialised. This is sadly a

dup of #826 , the fact that we hadn't considered inbound emails fully. Thanks for the report and I'm very sorry about this! I'm going to close in favour of # 826.

OK. I did look to see if this was already reported. I read #826, but it didn't seem to cover my issue. I saw the title of #820, but again no clue that it was related, and reading it it is all talking about html mail.

So long as you understand what's broken, and that it's pretty fundamental for text email users.

I got a good message at Sat, 15 Dec 2018 15:07:40 +0000 so I guess you fixed it/reverted something.

Cheers for the quick response.

Wookey -- Principal hats: Linaro, Debian, Wookware, ARM http://wookware.org/

nikolai-b commented 5 years ago

Sorry, I now see the issue I wrote is very unclear. I've updated it and just push what I hope is a fix. It is very hard to test the email fully so please let me know if there is something amiss.