search

cyclestreets / cyclestreets-r

An R interface to cyclestreets.net APIs
https://rpackage.cyclestreets.net/
GNU General Public License v3.0
27 stars 7 forks source link

Faster routing function #45

Closed Robinlovelace closed 1 year ago

Robinlovelace commented 1 year ago

Heads-up @mem48 I've tidied up your code, got everything into a consistent style, and updated the workflows on actions. Hopefully they pass now. Anything else we should do before merging? Ultimately we should seek to combine journey() and journey2() to reduce duplication of code, do we need both functions? Seeing as journey2() is not used yet, my thinking is integrate that functionality into journey() although that may be a lot of refactoring and not sure it's the best use of time ATM.

mem48 commented 1 year ago

The obvious thing would be to align journey2 features with journey. If you have a function to handle the elevation data it may not be much work.

But I agree not a priority.