72 extra column name associated with short routes

cyclestreets / cyclestreets-r

An R interface to cyclestreets.net APIs

https://rpackage.cyclestreets.net/

GNU General Public License v3.0

27 stars 7 forks source link

72 extra column name associated with short routes #73

Closed Robinlovelace closed 1 year ago

Robinlovelace commented 1 year ago

Set-up for debugging #72
Add example json for #72
Treat ProvisionName as variable, close #72

Robinlovelace commented 1 year ago

Heads-up @hussein-mahfouz, this was a hard-to-debug one associated with edge cases around the fact that some attributes returned by CycleStreets are invariable (they stay the same for each segment), while others like provisionName vary.

provisionName was incorrectly classified as an invariable attribute. It only affected the results for single segment routes. Not the best bit of code and could probably benefit from a big refactor at some point...