cyclestreets / tflcid-conversion

Conversion of TfL CID attributes to OSM
https://bikedata.cyclestreets.net/tflcid/conversion/
11 stars 3 forks source link

Cycle lane track colour field colours whole road #10

Closed RobJN closed 2 years ago

RobJN commented 5 years ago

As currently proposed surface:colour=blue on a cycle lane might be interpreted to mean the whole road. Why?

Perhaps cycleway:lane:colour= instead (matches the existing cycleway:lane:width= tag). The surface:colour=* tag would be ok on a highway=cycleway.

RobJN commented 5 years ago

Hold on. Sometimes this will be the colour of a shared bus lane right? If so you will have an existing osm tag such as cycleway:left=share_busway. In which case the colour should be cycleway:left:colour=*.

matkoniecz commented 5 years ago

cycleway:surface:color?

mvl22 commented 2 years ago

cycleway:surface:color

Yes, I agree, that is what should be used.

Taginfo shows this is indeed in use.

cycleway:left=share_busway. In which case the colour should be cycleway:left:colour

Yes, correct that we should add the :left / :right if that is what we are attaching to.

@systemed Looks as if we didn't implement CLT_COLOUR, presumably hence this ticket. Action is:

Looks as if this will need a schema change to add that field, judging from the current table definition.

systemed commented 2 years ago

The lingua franca of OSM is British English, so cycleway:surface:colour of course ;)

mvl22 commented 2 years ago

Apologies, yes, of course. Comes of having coded CSS earlier in the day :) I've edited the above post to avoid any confusion or copy-and-paste issues.

Also fixed in schema documentation in pull request #9.