cycloidio / raws

[UNMAINTAINED] AWS Reader
MIT License
15 stars 0 forks source link

Upgrade Go to 1.10 #27

Closed ifraixedes closed 6 years ago

ifraixedes commented 6 years ago

Upgrade the Go version to use the last stable release, the 1.10.

https://blog.golang.org/go1.10

xescugc commented 6 years ago

Something is wrong with the CI:

$ go version
go version go1.1 linux/amd64

This issue is tracked on: https://github.com/travis-ci/gimme/issues/132

ifraixedes commented 6 years ago

We'll wait for it.

xescugc commented 6 years ago

We could potentially use the 1.10.x

xlr-8 commented 6 years ago

Apparently this was closed: https://github.com/travis-ci/gimme/issues/132#event-1486436751

ifraixedes commented 6 years ago

I relaunch the CI from the travis interface, but the same problem raised :|

I'm going to repush it and see if that can change something in the next build that isn't applied doing the relaunch from the UI.

ifraixedes commented 6 years ago

It's still failing.

I've never setup travis, so I'm not very experienced with it and I don't know how it was setup here.

I see that the issue is related to something called gimme, @xlr-8 are we using that think for the travis configuration of this project or it's something that's used when Go is configured?

xlr-8 commented 6 years ago

According to the issue, it's because "1.10" has to be used - with the quotes, not alone, see commits/comments after the issue had been closed.

ifraixedes commented 6 years ago

oh my god, but that has been always there; it has been better to tell me directly to wrap the version in quotes than pointing to the issue, I totally missed the part of wrapping it.

@xlr-8 thanks!

xlr-8 commented 6 years ago

sorry, we'll do next time!

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 84.473% when pulling 79b8285ff30b4d8e6b9e9f1fa483d6889b8a8317 on if-upgrade-go-1.10 into 53ad9e72656c63e7f4d82dfc3046f7a186ebc106 on master.