search

cycloidio / raws

[UNMAINTAINED] AWS Reader
MIT License
15 stars 0 forks source link

Should we consider to use an assertion package in the tests? #32

Open ifraixedes opened 6 years ago

ifraixedes commented 6 years ago

Should consider to use any any assertion library for the test of this package?

In case that yes, which one

  1. https://godoc.org/github.com/stretchr/testify/assert
  2. https://github.com/test-go/testify (fork of option 1)
  3. Any other? (please suggest)

The goal isn't to refactor the current tests for only this purpose, but if we agree in using one, who write a new test or need to change any test could use it without asking at that moment, which always delays the progress.

On the other hand, we could decide to enforce the usage of the one agreed in the new tests and when the existent ones be drastically refactored.

xescugc commented 6 years ago

I would go for option 1) and enforce the use of it, it'll make the tests more readable and easy to work with.

And at some point migrate the tests that we have to it to have all the tests use the same lib.