cycloidio / raws

[UNMAINTAINED] AWS Reader
MIT License
15 stars 0 forks source link

Should we change the makefile to be more Goish? #34

Closed ifraixedes closed 5 years ago

ifraixedes commented 6 years ago

As commented in https://github.com/cycloidio/raws/pull/31#discussion_r173847046 the Makefile targets doesn't follow the convention which has been taken by the most of the Go tools, which is to be silent if everything is OK or in case of having a verbose option if it isn't enabled.

The Makefiles, requires some minor homogenizations (use printf rather than echo command as @xlr-8 has mentioned), however if the goal is to change to be more Goish, then there is no need to have such minor changes as we could change it entirely.

I cannot say why the Makefile is this way, so I'm not writing here any reason or favor on the current way, because, basically, I don't know.

The question is, should we change it to be more Goish?

xescugc commented 6 years ago

I would say yes because for example, having by default the test be with the -v is a bad idea, once you have more that 50 test the output is totally unreadable.

The other outputs that say ok [...] makes the User read those outpus because maybe they are importan, when they are just saying that everithing was ok, so nothing to read there.

That's the way I see it, and basically the go tools follow this approch of only printing what it has value to be read.

ifraixedes commented 6 years ago

I'm the one that think that the most of the times log files should only contains actionable information, so it makes clear my preference.

xlr-8 commented 6 years ago

I'm fine with both, I'd rather use printf as it seems more adapted for every platform.

While for the message, we could indeed reduce the output. I still like a summary of 'ok/ko' for simple test, and 'ok/all-error-messages' for more complex ones (so basically what go does)

ifraixedes commented 6 years ago

I'm fine with both, I'd rather use printf as it seems more adapted for every platform.

That's fine

However the question is more about if we suppress the ok messages?