cycloidio / terracognita

Reads from existing public and private cloud providers (reverse Terraform) and generates your infrastructure as code on Terraform configuration
MIT License
2.17k stars 163 forks source link

Wrong rendering of metric_query yaml #261

Open marcobazzani opened 2 years ago

marcobazzani commented 2 years ago

General information:

Describe the bug:

I just want to import all alarms and edit them terracognita aws --tfstate resources.tfstate --hcl main.tf -i aws_cloudwatch_metric_alarm completes tf plan returns many errors like this:

│ Error: Unsupported block type
│
│   on main.tf line 511, in resource "aws_cloudwatch_metric_alarm" "one_or_more_hosts_are_unhealthy":
│  511:       dimensions {
│
│ Blocks of type "dimensions" are not expected here. Did you mean to define argument "dimensions"? If so, use the equals sign to assign it a value.
╵

fragment starting at line 507:

  metric_query {
    id = "m4"
    metric {
      dimensions {
        LoadBalancer = "app/k8s-commonpublicalb-a48c003731/6100727d823ac3a8"
        TargetGroup  = "targetgroup/k8s-homeins-mobilitu-863904c84c/3395c10ec31fb55b"
      }

      metric_name = "UnHealthyHostCount"
      namespace   = "AWS/ApplicationELB"
      period      = 60
      stat        = "Maximum"
    }

  }

Log message

marcobazzani commented 2 years ago

I've fixed by substituting dimensions { with dimensions = {