search

cyclops-community / ctf

Cyclops Tensor Framework: parallel arithmetic on multidimensional arrays
Other
201 stars 53 forks source link

Compile error on BG/Q #5

Closed justusc closed 9 years ago

justusc commented 9 years ago

Compile fails on BG/Q due to a dangling "else" in src/mapping/topology.cxx on line 144. It looks like the else should be deleted, but it is not clear if that is the intent of the code.

The compiler used to build the code is BG Clang 3.7.

The build output is given below.

make -C mapping
make[3]: Entering directory `/gpfs/mira-home/justusc/src/ctf/src/mapping'
mpic++11 -O3 -std=c++11 -fopenmp   -DBGQ -D_POSIX_C_SOURCE=200112L -D__STDC_LIMIT_MACROS -DFTN_UNDERSCORE=1  -I/soft/libraries/essl/current/include -c mapping.cxx
mpic++11 -O3 -std=c++11 -fopenmp   -DBGQ -D_POSIX_C_SOURCE=200112L -D__STDC_LIMIT_MACROS -DFTN_UNDERSCORE=1  -I/soft/libraries/essl/current/include -c distribution.cxx
mpic++11 -O3 -std=c++11 -fopenmp   -DBGQ -D_POSIX_C_SOURCE=200112L -D__STDC_LIMIT_MACROS -DFTN_UNDERSCORE=1  -I/soft/libraries/essl/current/include -c topology.cxx
topology.cxx:154:5: error: expected statement
    } else if (mach == TOPOLOGY_BGP) {
    ^
1 error generated.
make[3]: *** [topology.o] Error 1
make[3]: Leaving directory `/gpfs/mira-home/justusc/src/ctf/src/mapping'
make[2]: *** [mapping] Error 2
make[2]: Leaving directory `/gpfs/mira-home/justusc/src/ctf/src'
make[1]: *** [ctf] Error 2
make[1]: Leaving directory `/gpfs/mira-home/justusc/src/ctf'
make: *** [lib/libctf.a] Error 2
111
solomonik commented 9 years ago

Fixed, but the performance of v1.22 on BG/Q is really bad with clang.