search

cyclops-ui / cyclops

Developer Friendly Kubernetes 👁️
https://cyclops-ui.com
Apache License 2.0
2.48k stars 779 forks source link

Add reconciliation timestamp to the Module CRD #430

Open petar-cvit opened 3 months ago

petar-cvit commented 3 months ago

Is your feature request related to a problem? Please describe. There is currently reconciliation status on the Module CRD, but another useful information to add to the status would be to add the time when the reconciliation finished. Also, the time should be then propagated to the history entry.

Describe the solution you'd like As a solution, we should add a new field to the reconciliation status and map it when setting the status of the module after reconciliation.

SpiffyEight77 commented 3 months ago

Hey @petar-cvit, I'm interested in this issue. Could you please assign it to me? 🙇🏻‍♂️

petar-cvit commented 3 months ago

@SpiffyEight77 do you have any updates on the issue?

SpiffyEight77 commented 3 months ago

@petar-cvit I apologize for my delayed response. I've been extremely busy with work and will be until October, so I don't think I'll have enough time to complete this task. I've removed myself from the assignment.

Abiji-2020 commented 2 months ago

@petar-cvit I could work on this issue Things needed to be done :

petar-cvit commented 2 months ago

@Abiji-2020 yup, that sounds good. Just make sure that after you update the struct in go, you generate the manifests using make generate and make manifests and apply created manifests to your cluster

petar-cvit commented 2 months ago

Hey @Abiji-2020, do you have any updates on the issue? Let me know if you have any questions

Abiji-2020 commented 2 months ago

I have a doubt that currently before updating the code I tried to run the Makefile to generate but it is giving me nil pointer error and with no further details. So I am struck in that process

petar-cvit commented 2 months ago

Hey @Abiji-2020, thanks for bringing this up.

There is a mismatch between go and controller-gen versions. I bumped the controller-gen version in #540. Sync your fork and pull the latest main branch.

To install a new version and generate manifests, run the following commands from the cyclops-ctrl folder.

Remove previous controller-gen:

rm -rf bin

Install the new version:

make controller-gen

and then you can generate code (make generate) and manifests (make manifests).

Abiji-2020 commented 2 months ago

oh okay, I was a beginner so I was wondering whether I am doing anything wrong here