Open petar-cvit opened 2 months ago
pravintargaryen
commented
2 months ago Hi @petar-cvit please review https://github.com/cyclops-ui/cyclops/pull/525 as the commit for this also ended up in the same PR. Please reject (https://github.com/cyclops-ui/cyclops/pull/525/commits/8c062f57c154dd8e8a12129edc1ac1db621bf6fc) and I will send a separate PR
petar-cvit
commented
2 months ago Hey @pravintargaryen, can you close the existing PRs and create new ones with changes only for a single issue?
pravintargaryen
commented
2 months ago @petar-cvit please check
quest-bot[bot]
commented
1 month ago 
New Quest!A new Quest has been launched in @cyclops-ui’s repo. Merge a PR that solves this issue to loot the Quest and earn your reward.
Some loot has been stashed in this issue to reward the solver!
🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!
⚔️ When you submit a PR, comment @quest-bot loot #524 to link your PR to this Quest.
Questions? Check out the docs.
pravintargaryen
commented
1 month ago @quest-bot embark
quest-bot[bot]
commented
1 month ago @pravintargaryen has embarked on their Quest. 🗡
JavaScript and HTML magic ✨Questions? Check out the docs.
Is your feature request related to a problem? Please describe. When fetching private templates, Cyclops injects auth data (username and password) into the request. This is supported only when fetching templates from GitHub, but not when fetching from an OCI registry.
Here is the example of how credentials are fetched from the cluster when fetching a template from GitHub and here is the function fetching data from an OCI based registry.