search

cyclops-ui / cyclops

Developer Friendly Kubernetes 👁️
https://cyclops-ui.com
Apache License 2.0
2.48k stars 781 forks source link

Add tooltip to resource not needed warning #644

Open KaradzaJuraj opened 2 weeks ago

KaradzaJuraj commented 2 weeks ago

Move the warning sign next to the resource name and status. Add a tooltip when hovering over the warning icon that displays “This resource is not used by the module anymore and can be deleted.”

To get the warning sign, you can use the demo template:

  1. deploy it with the service toggled on
  2. Edit the module and toggle the service off
  3. now you will have the warning sign on the service
quest-bot[bot] commented 2 weeks ago

New Quest! image New Quest!

A new Quest has been launched in @cyclops-ui’s repo. Merge a PR that solves this issue to loot the Quest and earn your reward.

Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #644 to link your PR to this Quest.

Questions? Check out the docs.

ArnavK-09 commented 2 weeks ago

can you specify location?

"next"

image

ArnavK-09 commented 2 weeks ago

@quest-bot embark

quest-bot[bot] commented 2 weeks ago

@ArnavK-09 has embarked on their Quest. 🗡

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

ArnavK-09 commented 2 weeks ago

Move the warning sign next to the resource name and status.

and do i have to remove warning signs from here?

image

KaradzaJuraj commented 2 weeks ago

Hey @ArnavK-09, you currently already have two PRs open. Please finish those before starting new issues.

ArnavK-09 commented 1 week ago

can you review em

AkashJana18 commented 6 days ago

@quest-bot embark

quest-bot[bot] commented 6 days ago

@AkashJana18 has embarked on their Quest. 🗡

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

AkashJana18 commented 6 days ago

Hey @KaradzaJuraj,

I’m working on moving the warning sign next to the resource name and status, with a tooltip that displays “This resource is not used by the module anymore and can be deleted.” I’d appreciate a few clarifications to ensure it’s implemented accurately:

  1. Positioning of Warning Sign: Could you specify the exact placement of the warning icon relative to the resource name and status? For example, should it appear on the left, right, or directly adjacent to the status text?

  2. Tooltip Trigger: Should the tooltip appear when hovering over just the warning icon, or would you like it to also trigger when hovering over the resource name and status?

  3. Warning Sign Activation: After deploying the demo template with the service toggled on and then toggling it off, should the warning icon only appear when the module recognizes that the resource is unused, or immediately upon toggling off?

  4. Styling Preferences: Are there any specific styles or design elements for the warning icon that need to match other UI components, or should it follow the default warning icon style?

Thank you for the additional guidance!

KaradzaJuraj commented 1 hour ago

Hey @AkashJana18

  1. To the right of the name and status
  2. Trigger only when hovering over the warning sign
  3. When the module recognizes that the resource is unused (but shouldn't matter in this issue)
  4. Use the same warning icon that is used now

I hope this clears things up; if you have any other questions - reach out!