search

cyclosproject / ng-openapi-gen

An OpenAPI 3.0 codegen for Angular
MIT License
397 stars 132 forks source link

new feature: add customizedResponseType to enable customizable respon… #145

Closed pillsilly closed 3 years ago

pillsilly commented 3 years ago

Hi this PR is associated with https://github.com/cyclosproject/ng-openapi-gen/issues/140

luisfpg commented 3 years ago

Hi @pillsilly, thanks for the PR. It seems good. But there are some failing tslint rules, which prevent build. Try running npm run build and you'll see the errors. Currently:

ERROR: /home/luis/git/ng-openapi-gen/lib/cmd-args.ts:121:2 - file should end with a newline
ERROR: /home/luis/git/ng-openapi-gen/lib/options.ts:90:14 - " should be '
ERROR: /home/luis/git/ng-openapi-gen/lib/options.ts:90:30 - " should be '
ERROR: /home/luis/git/ng-openapi-gen/lib/options.ts:90:39 - " should be '
ERROR: /home/luis/git/ng-openapi-gen/lib/options.ts:90:48 - " should be '
ERROR: /home/luis/git/ng-openapi-gen/lib/options.ts:92:4 - Missing semicolon
ERROR: /home/luis/git/ng-openapi-gen/test/all-operations.spec.ts:17:5 - Missing semicolon
ERROR: /home/luis/git/ng-openapi-gen/test/all-operations.spec.ts:454:16 - " should be '
ERROR: /home/luis/git/ng-openapi-gen/test/cmd-args.spec.ts:6:5 - Missing semicolon
ERROR: /home/luis/git/ng-openapi-gen/test/cmd-args.spec.ts:21:9 - " should be '
ERROR: /home/luis/git/ng-openapi-gen/test/cmd-args.spec.ts:22:11 - " should be '
ERROR: /home/luis/git/ng-openapi-gen/test/cmd-args.spec.ts:22:20 - " should be '
ERROR: /home/luis/git/ng-openapi-gen/test/cmd-args.spec.ts:25:7 - Missing semicolon
ERROR: /home/luis/git/ng-openapi-gen/test/cmd-args.spec.ts:31:7 - Missing semicolon

Please, fix them. I'll merge afterwards.

pillsilly commented 3 years ago

Thanks, I missed that. Will provide fix soon 🤝

pillsilly commented 3 years ago

comment fixed, @luisfpg please check.

thank you.

pillsilly commented 3 years ago

@luisfpg would you re-check this PR thanks