search

cyclosproject / ng-openapi-gen

An OpenAPI 3.0 codegen for Angular
MIT License
397 stars 132 forks source link

feat: accept default as a success response #208

Closed marcellkiss closed 2 years ago

marcellkiss commented 2 years ago

Closes #204 As we've already discussed in #204, this change enables default responses to be used as success responses.

luisfpg commented 2 years ago

Regarding prettier, I don't use it, but the built-in vscode formatter instead. About the other issue, sorry, my bad. It should work as is. At first glance it seemed wrong... Ok, just waiting for a test case then!

marcellkiss commented 2 years ago

@luisfpg have a look at it, now it look better

luisfpg commented 2 years ago

I'm just starting my vacations, so I won't be able to look at this in the coming days, sorry... When I'm back, I'll take a look. Thanks for the PR.

marcellkiss commented 2 years ago

Sounds good, have a nice holiday! On Feb 4, 2022, 18:29 +0100, Luis Fernando Planella Gonzalez @.***>, wrote:

I'm just starting my vacations, so I won't be able to look at this in the coming days, sorry... When I'm back, I'll take a look. Thanks for the PR. — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: @.***>

marcellkiss commented 2 years ago

Hi @luisfpg, could you have a look at it meanwhile? Thanks!

luisfpg commented 2 years ago

Sorry for the delay. I'll try to publish this in a new version today