cyclosproject / ng-openapi-gen

An OpenAPI 3.0 codegen for Angular
MIT License
397 stars 132 forks source link

Handeling of single character identifiers in object generation not correct #250

Closed VP-GAMES closed 1 year ago

VP-GAMES commented 1 year ago

Template:

"MyClass": {
  "type": "object",
  "properties": {
    "x": {
      "type": "number",
      "format": "double"
    },
    "y": {
      "type": "number",
      "format": "double"
    }
  }
}

Generated interface:

export interface MyClass {
  'x': number;
  'y': number;
}

To be right generated interface:

export interface MyClass {
  x: number;
  y: number;
}

Problematic code: https://github.com/cyclosproject/ng-openapi-gen/blob/888560c2d3f97dcd64888b936cd9642ebafd8657/lib/gen-utils.ts#L153 Fix for this: https://github.com/cyclosproject/ng-openapi-gen/pull/249