cyclus / cycamore

The CYClus Additional Module REpository
Other
15 stars 40 forks source link

cycamore::Reactor should have decommissioned reactors in the agentstate_cycamore_reactorinfo table #459

Open jbae11 opened 7 years ago

jbae11 commented 7 years ago

Current:

The table agentstate_cycamore_reactorinfo does not have
decommissioned reactors (reactors which have exited in the simulation). This complicates analytics since metrics such as the power_cap column are only accessible
in the agentstate_cycamore_reactorinfo table. A discussion of this concern can be found in this issue: Europe Case Study

Demonstration of Problem:

The following query on the cyclus.sqlite database outputs blank, in any simulation with cycamore::DeployInst:

SELECT power_cap, entertime
FROM agentexit INNER JOIN
agentstate_cycamore_reactorinfo
ON agententry.agnetid = agentstate_cycamore_reactorinfo.agentid

I also tried using other tables, but it seems that the 'agentstate_cycamore_reactorinfo is the only table with the columnpower_cap`.

If this were fixed, it would be easier to display the capacity fluctuation
with time if there are reactor agents with more than one unique capacity.

katyhuff commented 7 years ago

Workaround discussed here: https://github.com/arfc/transition-scenarios/issues/22