search

cyclus / cycamore

The CYClus Additional Module REpository
Other
15 stars 39 forks source link

Update newer test classes to skip if cyclus does not have COIN #601

Closed bennibbelink closed 5 months ago

bennibbelink commented 5 months ago

In a handful of places the method being used to skip tests is different than the standard method (skip_if_dont_allow_milps()). This has not been tested in CI since we always install cyclus and cycamore with the --allow-milps flag and COIN. I tested this locally to confirm that the correct tests are now skipped when cyclus and cycamore are installed without MILPS support - I encourage any reviewers to test locally as well

If we wish to hold this back until CI is in place to test, that is fine with me. Currently all of our distribution methods build cyclus and cycamore with COIN support so this might not be super pressing

github-actions[bot] commented 5 months ago

Build Status Report - a783156bdf3a3d7473cd14c59cab72d3dc1d020f - 2024-04-30 13:56:59 -0500

Build FROM cyclus_20.04_apt/cyclus:latest
Build FROM cyclus_20.04_apt/cyclus:stable
Build FROM cyclus_20.04_conda/cyclus:latest
Build FROM cyclus_20.04_conda/cyclus:stable
Build FROM cyclus_22.04_apt/cyclus:latest
Build FROM cyclus_22.04_apt/cyclus:stable
Build FROM cyclus_22.04_conda/cyclus:latest
Build FROM cyclus_22.04_conda/cyclus:stable
gonuke commented 5 months ago

I tested with and without this patch and it solved the problem. Thanks @bennibbelink