MassUnit should probably be a Unit class

cyclus / cyclus

The Cyclus Nuclear Fuel Cycle Simulator

http://fuelcycle.org/

Other

78 stars 70 forks source link

MassUnit should probably be a Unit class #485

Open katyhuff opened 11 years ago

katyhuff commented 11 years ago

There is some room to refactor the MassUnit typedef we currently use (as well as lots of other unit typedefs one would find if they look into the Cyder tool) to define various material amounts into a more generic Unit class that could contain a whole array of unit types, unit conversions, etc.

This is obviously not urgent, but it would be a helpful addition to the core and might tie closely with solutions derived in support of the unit definition needs of Cycic. ( so, this is related to the issue https://github.com/cyclus/cyclus/issues/380 ) .

rwcarlsen commented 11 years ago

I have some ideas for nifty ways to handle units, but I think we should put this on the backburner until we nail down a solid, clean, good, new material (and friends) interface. Anthony, Matt, and I (and others) have expressed a desire to cleanup and simplify the interface. This will probably be a part of that larger effort that will likely happen over the summer.

katyhuff commented 11 years ago

I think a lot of us have nifty ideas for how to handle units. I hope I can be involved in those discussions. I agree that it can be on the backburner (thus "This is obviously not urgent,").