search

cyclus / cycstub

A repository providing a skeletal set of modules for use with the Cyclus fuel cycle simulator.
Other
0 stars 10 forks source link

Init compatibility #2

Closed katyhuff closed 12 years ago

katyhuff commented 12 years ago

These changes bring the CycStub files up to date with the initialization overhaul in the Cyclus core. They also bring the input file StubInput.xml up to date with those changes.

katyhuff commented 12 years ago

@cyclus/pushers , I'm not sure everyone's subscribed to changes/updates/pull requests in cycstub, so the purpose of this comment is to alert everyone that there is a pull request in cycstub bringing it up to date with the cyclus core.

gonuke commented 12 years ago

I'm assuming that there is no testing regime for cycstub (nor should there be). I think @gidden or @rwcarlsen should review this they were involved with the cycamore upgrade.

katyhuff commented 12 years ago

Well, there actually is a test driver for cycstub. It runs tests checking mostly whether anything in any of the stub models throws an exception when their expected interfaces are probed. That is, the CycStub test suite runs our FacilityModel/RegionModel/InstModel/etc. interface/acceptance tests and serves as a template for from-the-stub-developers to build their own tests. It can be run with ./bin/CycstubUnitTestDriver .

katyhuff commented 12 years ago

Ping, @gonuke @rwcarlsen @gidden, this pull request has now been languishing for over two weeks. Any chance one of you could give it a look? As a reminder, its purpose was to bring cycstub up to date with the initialization changes.

gidden commented 12 years ago

Looks good, the sim in /input/stub runs fine.