search

cyclus / cymetric

http://fuelcycle.org/user/cymetric/index.html
Other
5 stars 20 forks source link

New metrics to return Inventory table with quantity in units of kg/GWe #156

Closed louishartono closed 4 years ago

louishartono commented 4 years ago

Made some changes to metrics.py. Added a new metrics called "InventoryQuantityPerGWe" to return the inventory table with quantity in units of kg/GWe instead of kg and created some tests to check the expected output as well. Feel free to give feedback or suggestions :).

bam241 commented 4 years ago

@louishartono you should also take the time to explain what this is about in the description of the PR, so other people get some content :)

bam241 commented 4 years ago

@louishartono added the [WIP] tag to allow other developers to know that this work is still ongoing and not ready to be included in the main repo.

bam241 commented 4 years ago

looking good for me. I'll let @gonuke merge.

gonuke commented 4 years ago

Thanks for this first contribution @louishartono !