Closed katyhuff closed 9 years ago
This portion was written originally by @scopatz, is memory serves. I agree that it is a strong claim; however, the claim is derived from the cited paper (Macal, et. al.). A semi-formal proof exists in the paper. I think you're proposed fix is fine. Would you like me to make the commit and PR it?
On Mon, Mar 2, 2015 at 11:58 AM, Katy Huff notifications@github.com wrote:
Assigned #102 https://github.com/cyclus/fundamentals-paper/issues/102 to @gidden https://github.com/gidden.
— Reply to this email directly or view it on GitHub https://github.com/cyclus/fundamentals-paper/issues/102#event-244549377.
Matthew Gidden Ph.D. Candidate, Nuclear Engineering The University of Wisconsin -- Madison Ph. 225.892.3192
Oh, sorry, thought it was you. I'm happy to make the change. Thanks for the speedy feedback!
On Mon, Mar 2, 2015 at 10:05 AM, Matthew Gidden notifications@github.com wrote:
This portion was written originally by @scopatz, is memory serves. I agree that it is a strong claim; however, the claim is derived from the cited paper (Macal, et. al.). A semi-formal proof exists in the paper. I think you're proposed fix is fine. Would you like me to make the commit and PR it?
On Mon, Mar 2, 2015 at 11:58 AM, Katy Huff notifications@github.com wrote:
Assigned #102 https://github.com/cyclus/fundamentals-paper/issues/102 to @gidden https://github.com/gidden.
— Reply to this email directly or view it on GitHub <https://github.com/cyclus/fundamentals-paper/issues/102#event-244549377 .
Matthew Gidden Ph.D. Candidate, Nuclear Engineering The University of Wisconsin -- Madison Ph. 225.892.3192
— Reply to this email directly or view it on GitHub https://github.com/cyclus/fundamentals-paper/issues/102#issuecomment-76764611 .
From checking the history, I did not write this originally. My edits to this file have relatively minor. Though I do agree that the wording is too strong.
cool! Fixed now. Thanks both!
On Mon, Mar 2, 2015 at 10:11 AM, Anthony Scopatz notifications@github.com wrote:
From checking the history, I did not write this originally. My edits to this file have relatively minor. Though I do agree that the wording is too strong.
— Reply to this email directly or view it on GitHub https://github.com/cyclus/fundamentals-paper/issues/102#issuecomment-76766259 .
Hi @gidden - I was going through some suggestions made by Erich for the Fundamentals paper and I ran accross one that I didn't feel like I could handle on my own. The paragraph in question is in the impl.tex file:
The comment from Erich is:
I would suggest this simple change:
The final sentence of the paragraph:
could become:
What do you think?