search

cyclus / recycle

Contributed Cyclus-compatible modules, more advanced than those available in Cycamore.
Other
1 stars 6 forks source link

Stub #4

Closed bam241 closed 6 years ago

bam241 commented 6 years ago

Everything has been changed from cycamore::xxx to recycle::xxx.

The Cycamore archetypes are not deleted (yet) to make sure tests work properly.

Thanks to @bam241 for great help.

To address issue #1 , an additional PR should be placed deleting all the cycamore archetypes,

which shouldn't be too hard.

bam241 commented 6 years ago

@jbae11 I don't know what I did, but I got it to work :)

Actually I believe that circle-CI/recycle project need to be alive before a PR is issued to have the automatic hook working.

bam241 commented 6 years ago

ok actually I don't understand why this one don't trigger the test but #5 does :(

bam241 commented 6 years ago

might be because you where not in the cyclus group

jbae11 commented 6 years ago

@bam241 interesting.. This PR is made by you too, right? what do you suggest we do from here?

bam241 commented 6 years ago

first accept the invitation to join CYclus group member. then close and reopen the PR ?