search

cyclus / recycle

Contributed Cyclus-compatible modules, more advanced than those available in Cycamore.
Other
1 stars 6 forks source link

stub facility for building #8

Closed jbae11 closed 4 years ago

jbae11 commented 6 years ago

I have added a stub_facility for the recycle library to build,

since the build will fail if there are no archetypes to build.

The build succeeded in my machine. Please let me know how it goes.

This will (hopefully) be the final phase of recycle initialization, with the previous

archetype histories deleted, and the cyclus:master branch building successfully.

The stub_facility will eventually be deleted when an actual archetype in development

gets pushed to cyclus/recycle:master

katyhuff commented 6 years ago

This seems broken. What's up? @jbae11

jbae11 commented 6 years ago

@katyhuff In the current status, it builds and runs. I have also just fixed the unit test so that it will pass, but since the StubFacility does nothing (prints hello at tick and world at tock), the tests really hold no value. The nosetest fails because it is based on cycamore archetypes. I was hoping the first person who comes up with an archetype will edit the nosetests to fit his/her archetype.

katyhuff commented 6 years ago

The nosetests are still failing. We don't pull in failing builds.

jbae11 commented 6 years ago

@katyhuff nosetest components were deleted so that the ci passes. I can't really think of another way to make this pass given that there is no archetype yet. Do you have any suggestions?

katyhuff commented 6 years ago

Why do we need this stub facility at all if it doesn't pass the tests and is just going to be deleted as soon as another facility is made?

jbae11 commented 6 years ago

I think the whole point was to provide a working template for people to fork and build their archetypes on top of. The stub facility the template that can sort of guide people and get them started by changing few things around, rather than from starting from scratch.

katyhuff commented 6 years ago

I know that. In cycamore, the stub facility doesn't cause failed tests, nor does it have to be removed, as suggested above, once other facilities appear.

jbae11 commented 6 years ago

I'm not sure if I understand. All the tests have passed (that's what github is showing me). Do you want me to delete the stubfacility?

katyhuff commented 6 years ago

They only passed because they were deleted halfway through this conversation. Deleting this file (tests/test_run_inputs.py) in particular will disable input checking tests for future archetypes. Deleting the readme (rather than editing it) is also ill-advised. The other file deletions seem like thye're probably ok.

katyhuff commented 6 years ago

This still seems to have been handled poorly. @jbae11 , please resolve.

jbae11 commented 5 years ago

I've added back the files (readme and test_run_inputs)! Once @gtw2 pushes his Pyre and tests, the stubfacility can be deleted.