cyd01 / KiTTY

:computer: KiTTY, a free telnet/ssh client for Windows
https://www.9bis.com/kitty
Other
1.61k stars 137 forks source link

Window title doesn't work #451

Closed kiber-io closed 1 year ago

kiber-io commented 1 year ago

Hi! KiTTY ver: 0.76.1.2 Faced with the fact that windows title does not change any variables to real values, leaving them raw in the title. For example, I want to set a simple title: %%u@%%s but in the end I get this изображение This is when the "Disable remote-controlled window title changing" function is disabled (because I want to uniquely separate connection windows by title, I need my own title there, for example, the name of the session). If you enable this function, the header shows information from the server (correctly) изображение They don't work on custom variables. I tried to write with 1 percent sign, and edit with my hands in the session config - the result is always the same:( In the session file, it looks like this if you set the header via gui: WinTitle\%25%25u@%25%25s\. In the interface so: изображение This is a problem both in the portable version and in the regular one.

msebald commented 1 year ago

I can confirm this issue. Same problem here since the last upgrade to 0.76.1.2p.

jtulp commented 1 year ago

Me too, with "kitty_nocompress.exe" 7.16.1.0 worked fine, latest version shows "%%s".

Fredrik-69 commented 1 year ago

Well, the release notes say: Switch back to original window title managment, prior to major refacto.

...which seem to be accomplished in file windows.c on line 7668 with the following statement:

ifdef MOD_PERSO1

So, something with the code for "original window title managment" isn't working.

tb4jc commented 1 year ago

Same problem for me, just seeing "%%s"

dlong500 commented 1 year ago

This really needs to get patched soon. Another headache is that when remotely connecting to another system via ssh in a kitty instance the title may keep remote system text so it's hard to determine which system to which the shell is actually connected.

kiber-io commented 1 year ago

@dlong500 If I understood correctly, then the "Terminal -> Features -> Disable changing the title of the window with remote control" is responsible for this

dlong500 commented 1 year ago

@kiber-io That setting may relate to changing the window title when remoting into another system, but this new regression is what breaks all sorts of window title functionality. It goes blank, doesn't update properly, shows unresolved variables, etc. Basically the window title is completely unreliable at this point.

EDIT to clarify, I mean that after closing a remote ssh connection to another system from within a kitty instance the (now disconnected) remote system title info is still showing in the title bar. So in that case the title bar would lead you to believe you are still connected to the remote system when you aren't.

@cyd01 Don't mean to pressure you and I know that I'm not paying anything, but can we get an acknowledgement of this issue? I noticed a new update (v0.76.1.3) yesterday but this issue persists.

dlong500 commented 1 year ago

@cyd01 I hope nothing is wrong healthwise and maybe you're just super busy. Just pinging you with this window title issue again as it is difficult to work with multiple kitty instances without working title bars.

cyd01 commented 1 year ago

Title management was disable due to memory crashes I did not have time to analyse: https://github.com/cyd01/KiTTY/releases/tag/v0.76.1.2