search

cyfronet-fid / marketplace

Marketplace is a place where you can find services you need for your research
https://marketplace.eosc-portal.eu
GNU General Public License v3.0
21 stars 6 forks source link

Technical Parameters do not display correctly in the offers #2399

Closed Marcelinna closed 2 years ago

Marcelinna commented 2 years ago

Tested v3.25.0-beta.0 Describe the bug The technical parameters aren't visible under the description of the offer for the person ordering the resource. There is a difference between what parameters are seen by the end-user and the person with administrator privileges

To Reproduce Steps to reproduce the behavior:

  1. Go to 'beta.marketplace.eosc-portal.eu'
  2. Find the resource whose offer has technical parameters (e.g B2SAFE --> /services/b2safe) image image
  3. Go to ordering_configuration page (for B2SAFE --> /services/b2safe/ordering_configuration) image
  4. See problem - on the resource page the user does not see all the technical parameters on offer

Expected behavior All technical parameters are visible under the description of the offer for the person ordering, browsing the resource.

Additional context Possible cause: the display of technical parameters depends on their type: Constant parameter -string (technical parameters aren't visible) image Constant parameter -integer (technical parameters are visible) image

jswk commented 2 years ago

I'm not sure this issue is valid.

The parameter filtering was introduced in scope of #390 (and PR #429) and hasn't been altered a lot since, apart of adding the "input" to EXCLUDED_TYPES. Based on this history, this feature was deliberate. Therefore, this ticket must have a clear motivation for removing this functionality. I miss the necessary context to judge this unambiguously (neither the original ticket, nor the PR, nor the commit messages provide a motivation, so it seems that @michal-szostak is the only person to left to provide some insight).

@michal-szostak, please have a look at this ticket and the associated PR #2439, and confirm that we indeed don't need the filtering anymore.

Marcelinna commented 2 years ago

The ticket was made at the request of the provider, communicated to me by @bwilk, @bwilk confirm we're fixing it? The ticket has been sent to the provider and and he expects it to be fixed

jswk commented 2 years ago

@bwilk says that the filtering feature is unnecessary anymore, and indeed a provider wants this filtering removed and we proceed with it.