Title after create new platform is not correct - Githubissues

cyfronet-fid / marketplace

Marketplace is a place where you can find services you need for your research

https://marketplace.eosc-portal.eu

GNU General Public License v3.0

21 stars 6 forks source link

Title after create new platform is not correct #2486

Open Marcelinna opened 2 years ago

Marcelinna commented 2 years ago

Describe the bug Tested on v3.29.0-beta.0

To Reproduce Steps to reproduce the behavior:

Go to '/backoffice/platforms'
Click on 'Add new platform'
Fill fields and click "Create Platform"
See error - page title is

Expected behavior the title should be platform.name - EOSC Marketplace, please change the title for category too.

when creating new:

provider title is provider.name - EOSC Marketplace
category title is EOSC Marketplace
scientific domain is - _scientificdomain.name - EOSC Marketplace
vocabulary is vocabulary.name - EOSC Marketplace
resource is rescource.name - EOSC Marketplace

jswk commented 2 years ago

I'd suggest uncommenting the config.i18n.raise_on_missing_translations = true in config/environments/test.rb to identify more places like this.

It could be worth setting raise_on_missing_translations in development environment too, so that we identify as many missing keys as possible early on.

https://github.com/glebm/i18n-tasks seems interesting too, it has some methods to detect unused keys either. We could include it in our static code analysis for example.