cyga / www_fdw

fdw extension for postgres
http://wiki.postgresql.org/wiki/WWW_FDW
123 stars 21 forks source link

Doesn't compile against PostgreSQL 9.5rc1 #20

Closed robe2 closed 8 years ago

robe2 commented 8 years ago

api changed between 9.5beta2 and 9.5rc1. I think a lot of fdws are broken including this one.

src/www_fdw.c: In function 'www_fdw_handler':
src/www_fdw.c:350:32: warning: assignment from incompatible pointer type [enabled by default]
     fdwroutine->GetForeignPlan = www_get_foreign_plan;
                                ^
src/www_fdw.c: In function 'www_get_foreign_paths':
src/www_fdw.c:624:11: warning: passing argument 8 of 'create_foreignscan_path' from incompatible pointer type [enabled by default]
           NIL)); /* no fdw_private data */
           ^
In file included from src/www_fdw.c:20:0:
c:/MING64~1/projects/POSTGR~1/rel/PG9~2.5W6/include/server/optimizer/pathnode.h:82:21: note: expected 'struct Path *' but argument is of type 'struct List *'
 extern ForeignPath *create_foreignscan_path(PlannerInfo *root, RelOptInfo *rel,
                     ^
src/www_fdw.c:624:11: error: too few arguments to function 'create_foreignscan_path'
           NIL)); /* no fdw_private data */
           ^
In file included from src/www_fdw.c:20:0:
c:/MING64~1/projects/POSTGR~1/rel/PG9~2.5W6/include/server/optimizer/pathnode.h:82:21: note: declared here
 extern ForeignPath *create_foreignscan_path(PlannerInfo *root, RelOptInfo *rel,
                     ^
src/www_fdw.c: In function 'www_get_foreign_plan':
src/www_fdw.c:659:5: error: too few arguments to function 'make_foreignscan'
     );
     ^
In file included from src/www_fdw.c:21:0:
c:/MING64~1/projects/POSTGR~1/rel/PG9~2.5W6/include/server/optimizer/planmain.h:46:21: note: declared here
 extern ForeignScan *make_foreignscan(List *qptlist, List *qpqual,
                     ^
src/www_fdw.c: At top level:
src/www_fdw.c:157:13: warning: 'www_explain_foreign_scan' declared 'static' but never defined [-Wunused-function]
 static void www_explain_foreign_scan(ForeignScanState *node, ExplainState *es);
             ^
src/www_fdw.c: In function 'www_get_foreign_plan':
src/www_fdw.c:660:1: warning: control reaches end of non-void function [-Wreturn-type]
 }