Add overlay site support

cygwin / cygwin-install-action

GitHub action to install Cygwin

GNU General Public License v3.0

21 stars 10 forks source link

Add overlay site support #8

Closed kgraefe closed 1 year ago

kgraefe commented 1 year ago

This adds support for downloading packages from a custom overlay packages server. This requires being able to:

specify multiple sites as the overlay package server lacks the upstream packages
specify an additional public key for verifying the setup.ini on the overlay package server.

Background: I managed to build neovim and all the missing dependencies for Cygwin. Currently I am playing around with it to check that it works (for a couple of months probably). If things go well I am willing to maintain those packages. Until then I'd like to stay away from main Cygwin repository.

kgraefe commented 1 year ago

Note: this renames the site parameter to sites.

jon-turney commented 1 year ago

@me-and maybe you have some comments?

kgraefe commented 1 year ago

Some kind of test of some kind would be a nice addition, also

Unfortunately I have no clue how to test the new features. I thought about using the time machine with a version before the last signing key rotation for pubkeys but unfortunately they do not backup the signatures of setup.ini. I could use my own server but tbh it is meant to only live until I make the decision whether I bury the neovim-experiment or actually maintain it in Cygwin's main repository. So that's probably not a good choice for you to rely on that...

kgraefe commented 1 year ago

One hour later I found https://github.com/marketplace/actions/http-server-action . So I hand-crafted a Cygwin overlay package directory containing one package with a canary shell script, hosted that within the test case and used it for testing both multiple sites and a custom pubkey.

I also uploaded the private key (with no password) in case you need to modify the test repository.

jon-turney commented 1 year ago

One hour later I found https://github.com/marketplace/actions/http-server-action

It's unfortunately not well documented, but setup also accepts local and UNC paths, so there were possibly simpler ways to achieve this, but this is good.

Thanks very much for this!

kgraefe commented 1 year ago

For my own planning: are you going to make a new release soonish? (no pressure intended)

jon-turney commented 1 year ago

For my own planning: are you going to make a new release soonish? (no pressure intended)

Oh yeah, I should probably stick another tag on.