search

cyhjason29 / pe

0 stars 0 forks source link

Sequence diagram self-invocation #17

Open cyhjason29 opened 2 months ago

cyhjason29 commented 2 months ago

image.png

Are there supposed to be self-invocation activation bars for :Cashier?

soc-pe-bot commented 2 months ago

Team's Response

The Cashier class does not create another instance of itself when calculating. It just looks at the transactions attribute and does the computation itself.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I am not too clear on what that means, but assuming what is meant is that the Cashier class does not call another of its own method, then the self-invocation arrows are misleading and goes against the standard notation as per the textbook.

image.png

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** Because there is some hindrance to the understanding of the UML sequence diagram, it can no longer be considered as just a cosmetic issue, since it is unclear whether there is self-invocation or not.