Most sites missing buildings_od geojson

cyipt / actdev

ActDev - Active travel provision and potential in planned and proposed development sites

https://actdev.cyipt.bike

7 stars 3 forks source link

Most sites missing buildings_od geojson #105

Closed Siequnu closed 3 years ago

Siequnu commented 3 years ago

The majority of sites are missing the buildings_od geojson. This is a really cool sub-layer and would be great if these could be added.

Robinlovelace commented 3 years ago

Yes, and something mentioned by @MeganStreb is that a simple 'Trip attractors' layer showing schools, shops etc could be good. Not an MVP so will mark as a stretch issue but doable. This was just a byproduct of #28, good co-benefit of going down to the building level. I'm up for taking a look at some point so assigning to me.

Siequnu commented 3 years ago

Could buildings be done as a MVP, rather than stretch? Otherwise I'll remove that layer, as it's currently foreseen in the design.

Robinlovelace commented 3 years ago

Could buildings be done as a MVP, rather than stretch? Otherwise I'll remove that layer, as it's currently foreseen in the design.

It depends what you mean by buildings. Do you mean buildings within the site boundary? If so yes. Otherwise I think pre-determined 'Destinations' such as shops, schools, (and maybe office buildings) etc is a higher priority as a layer. That would be better than the dump of all buildings. Note that to fix https://github.com/cyipt/actdev/issues/35 I greatly broadened the definition of a building.

Siequnu commented 3 years ago

I'm happy with any of those — for me the priority is understanding which data layers to expose in the UI. Currently the buildings layer can (only?) be seen on the Great Kneighton site.

If a destinations geojson file is generated for each site I can quickly swap out the current buildings API call and visual toggle for that layer.

Robinlovelace commented 3 years ago

Plan:

[x] create site_buildings.geojson as that looks good
[x] create trip_attractors.geojson which is an important layer to show range of places people may need to visit beyond town and work.

Robinlovelace commented 3 years ago

Working on this. Heads-up @joeytalbot and @Siequnu as discussed today.

Robinlovelace commented 3 years ago

Update: I realised a the previous version of the script was treating any OSM polygon as a building! Fixed now.

Robinlovelace commented 3 years ago

Running this for all sites now.

Robinlovelace commented 3 years ago

Heads-up @mvl22 (and @Siequnu if still awake!) can you check the data just pushed in the commit above and let me know asap if there are any issues with this file format. Looks good to me!

Robinlovelace commented 3 years ago

Cool thing: it also shows the neat procgen_houses created by @dabreegster. They look good in Allerton Bywater to me!

https://github.com/cyipt/actdev/blob/main/data-small/allerton-bywater/site_buildings.geojson

Robinlovelace commented 3 years ago

And also heads-up Dustin, Purpose is incoming! (Note that in reality the majority of these are Commute not shopping trips, another crease to iron out, probably mostly on my side, at some point.)

mvl22 commented 3 years ago

Updated buildings URL so these will now come through.