cyipt / actdev

ActDev - Active travel provision and potential in planned and proposed development sites
https://actdev.cyipt.bike
7 stars 3 forks source link

8 sites missing in-site-metrics.csv #110

Closed Siequnu closed 3 years ago

Siequnu commented 3 years ago
Robinlovelace commented 3 years ago

These haven't yet been built. There is a 'built' TRUE/FALSE variable somewhere that defines this. Reasoning: hard to calculate metrics for places that do not yet exist.

mvl22 commented 3 years ago

Reopening so that @Siequnu can validate that this scenario is properly handled.

Robinlovelace commented 3 years ago

Shouldn't issues that can be fixed with code in the ui repo be tracked there? Will leave this one here for now but in general I suggest that is how we use issues: to track clearly actionable and well-defined tasks that have been decided on and can be fixed in code. On a wider note, comparing https://github.com/cyipt/acton/issues with https://github.com/cyipt/actdev/issues I think we've used issues more effectively this time around, but that's going further off topic!

mvl22 commented 3 years ago

Shouldn't issues that can be fixed with code in the ui repo be tracked there?

Yes, but it's 1am in the morning and my ability to disambiguate the two in a sea of notifications is perhaps lacking :)

Robinlovelace commented 3 years ago

Replaced by https://github.com/cyipt/actdev-ui/issues/32