search

cyipt / actdev

ActDev - Active travel provision and potential in planned and proposed development sites
https://actdev.cyipt.bike
7 stars 3 forks source link

No data dictionary for the ClockBoard infographics #130

Closed Robinlovelace closed 3 years ago

Robinlovelace commented 3 years ago

See https://github.com/cyipt/actdev-ui/issues/47#issuecomment-792351727. You up for taking a look at this @joeytalbot? Also interested to hear your thoughts on the most relevant variables to show - the great thing about the ClockBoard viz is you can see a simple graphical summary of many variables in one place which may raise further UI questions/issues. Heads-up on that @mvl22 although I think this one is back in our court for now ; )

mvl22 commented 3 years ago

Can this dictionary go in soon?

Am keen to close down https://github.com/cyipt/actdev-ui/issues/47 as it's been lingering but isn't really a UI issue that we can fix as such.

joeytalbot commented 3 years ago

I'll create one soon.

joeytalbot commented 3 years ago

@Robinlovelace in creating the data dictionary I think I've found an error in clockboard-zones.R https://github.com/cyipt/actdev/blob/52da9ee31f5e47b7e59a6cfcad343c578cc551c8/code/clockboard-zones.R#L105 busyness_mean_quiet relates to quiet cycle routes, but route_dist_cycled_dutch relates to fast cycle routes.

Robinlovelace commented 3 years ago

@Robinlovelace in creating the data dictionary I think I've found an error in clockboard-zones.R

Good catch. I think we need to update the geojson zones anyway so good timing.

Robinlovelace commented 3 years ago

103

joeytalbot commented 3 years ago

I've fixed this plus a second bug that meant we had the wrong results for circuity_cycle_quiet and quietness_diversion.

There's another problem - which I think is caused by the disaggregation code - that is preventing us from getting any figures for circuity_walk. At this stage i think it's best to just exclude circuity_walk.

mvl22 commented 3 years ago

Where is the file please? I still can't see it.

Robinlovelace commented 3 years ago

Ah yes. Please always add a link to the file or screenshot that has changed when closing issues everyone. It's good practice and makes it easier to track progress and confirm issues have been fixed, and plan for next steps as is the case here.

joeytalbot commented 3 years ago

I've pushed it now. It wasn't done when I wrote the last comment. https://github.com/cyipt/actdev/commit/678af320b7081e97f3ee7382f5640bd3ab6cc888