Abstreet new sites scenarios

[natesheehan]

Sanity checks all passing ✅

This PR contains

• compiled scenario_base.json, andscenario_go_active.json for the new sites added last week
• new site "newborough-road"
• refactoring of build.r to reintegrate abstr scenario autogeneration
• refactoring of abstr-scenarios.r for new sites (https://github.com/cyipt/actdev/issues/159)

[natesheehan]

Looks good to me. Are these based on the new procgen houses using the approach @dabreegster mentioned on Slack? An improvement in any case for sure, great to see the buildings in there, those can go straight up on the web app when we merge this.

Nope, not based on the new approach yet, this PR is mostly housekeeping . Should/do we import new sites to abstreet before we start using the new procgen house tool @dabreegster @Robinlovelace ?

[dabreegster]

Should/do we import new sites to abstreet before we start using the new procgen house tool

No, the other way around. I don't think you can generate the base/go active scenario JSONs without the procgen houses for some sites. So I would recommend 1) Adding in the procgen houses 2) Generating the scenario JSON 3) Doing the abstreet import once everything in data-small isn't going to change. (And recall that ultimately I have to run those steps, because of uploading to S3)

[Robinlovelace]

Any harm in merging this now @dabreegster ? I think not and it will be easy to update the relevant files after running the procgen import process but wanted to check in with your first from an abst perspective :eyes:

[dabreegster]

Any harm in merging this now

Nope, go for it

[natesheehan]

front end looks all good for actdev

[Robinlovelace]

:tada: fantastic. Many thanks for the great PR and checking it all works.