search

cyipt / actdev

ActDev - Active travel provision and potential in planned and proposed development sites
https://actdev.cyipt.bike
7 stars 3 forks source link

LCID default scenario does not contain trips originating in the development zone #174

Open Robinlovelace opened 3 years ago

Robinlovelace commented 3 years ago

Not sure what is causing this but having just demonstrated https://actdev.cyipt.bike/abstreet/?--actdev=lcid&--cam=14.95/53.79136/-1.53469&--actdev_scenario=base I noticed that people are not starting their morning commutes in the development location but seemingly anywhere on the map. Any ideas @dabreegster or @natesheehan ? Will check for other areas. This is what I see (note: LCID is roughly in the centre of the map but the highest flows are not emanating from the site):

image

Also it seems the site boundary is no longer there.

Robinlovelace commented 3 years ago

Update: seems people are correctly emanating from the Allerton Bywater site but the site boundary is not there.

image

Source: https://actdev.cyipt.bike/abstreet/?--actdev=allerton-bywater&--cam=12.44/53.75656/-1.41978&--actdev_scenario=base

natesheehan commented 3 years ago

I've had a quick look, and it looks like all the site boundaries aren't showing - I am also getting the same issue as @Robinlovelace for lcid, and unsure what the root issue is, as it's not the case for any other sites . Ill check through the geojson to see if I see anything funky

Robinlovelace commented 3 years ago

Heads-up, I think Dustin has identified the issue (updated A/B Street schema) and documented it here: https://github.com/a-b-street/abstr/issues/29 We could mark this as a duplicate but good to have an issue open in the ActDev repo as that's where people will look.

dabreegster commented 3 years ago

The missing study area polygon issue was fixed in https://github.com/a-b-street/abstreet/commit/ef907217415f0acb2d94480361e3a77ddc617914. Problem is, I don't push a new actdev release often, since it's so painful to upload a ~1GB zip. Last release was May 19, so it doesn't have this fix.

You can confirm the LCID site boundary is showing up in the latest web build: Screenshot from 2021-07-01 11-34-44 http://abstreet.s3-website.us-east-2.amazonaws.com/0.2.48/abstreet.html?--actdev=lcid&--cam=14.15/53.78484/-1.51527 Allerton is also fine.

I watched the LCID simulation (as of the 0.2.48 release) and saw trips coming from the new zone. So basically, this is fixed upstream, but we need to push a new actdev deployment. That's blocked on a-b-street/abstr#29.

Robinlovelace commented 3 years ago

Great work, thanks Dustin!