cyipt / actdev

ActDev - Active travel provision and potential in planned and proposed development sites
https://actdev.cyipt.bike
7 stars 3 forks source link

When I select the in-site network or journey times layers at Poundbury, it takes me to Tyersal instead #192

Closed joeytalbot closed 1 year ago

joeytalbot commented 2 years ago

There seems to be an error with the actdev tool for Poundbury. When I select the site layers for in-site network or journey times, instead of showing me these layers at Poundbury, it takes me to Tyersal Lane and shows me the layers at Tyersal Lane instead. This happens on both Chrome and Firefox. The other layers at Poundbury work as expected. I haven't noticed this happening with any other sites, though I haven't checked through all of the sites.

joeytalbot commented 2 years ago

Screenshot from 2022-05-23 11-19-24

mvl22 commented 2 years ago

OK, I can reproduce the issue.

  1. Go to https://actdev.cyipt.bike/poundbury/
  2. Click Route network button

Will look at this shortly.

mvl22 commented 1 year ago

OK, I've found the cause.

It's because the data is wrong. These are the files that you produced:

https://raw.githubusercontent.com/cyipt/actdev/main/data-small/poundbury/in-site-walk-rnet.geojson https://raw.githubusercontent.com/cyipt/actdev/main/data-small/poundbury/jts-lsoas.geojson

Poundbury is at this map location: 12/50.71374/-2.46471. Yet you can see these files contain data in locations like -1.735352, 53.819356, which is nowhere near.

All that's happening is that your data is being loaded, and the map is zooming to the bounding box of that data.

If you update the above files, the site will automatically catch them. Though bear in mind your browser may cache old files, so check in Incognito to be sure.

Robinlovelace commented 1 year ago

Good data sleuthing @mvl22. I've checked the data and it seems that the dataset is near Bradford: https://github.com/cyipt/actdev/blob/main/data-small/poundbury/in-site-walk-rnet.geojson

@natesheehan I think last updated this file, could you double check other files in that commit? I plan to revert the latest commit in that file in any case.

Robinlovelace commented 1 year ago

Good news, that seems to have fixed it: image

Does the updated app work for you @joeytalbot ?

joeytalbot commented 1 year ago

Yes it works now, thanks for fixing this Robin and Martin!